Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show spinner while ticket is being generated #560

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

podliashanyk
Copy link
Contributor

Closes #486

@podliashanyk podliashanyk added polish Nice to have usability Improves ease of use labels Apr 19, 2024
@podliashanyk podliashanyk self-assigned this Apr 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.50%. Comparing base (ba8a993) to head (cc1088b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
+ Coverage   57.35%   57.50%   +0.15%     
==========================================
  Files          86       86              
  Lines        3691     3697       +6     
  Branches      837      841       +4     
==========================================
+ Hits         2117     2126       +9     
+ Misses       1565     1562       -3     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@podliashanyk podliashanyk force-pushed the add-ticket-generation-feedback branch from 37d39a2 to d0793a7 Compare April 19, 2024 08:51
Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, the only small thing I noticed is that when I have Zoom at 100% the button moves when the loading icon is shown:

  1. Before generating a ticket:
    Screenshot from 2024-04-22 14-51-43

  2. While the ticket is generated:
    Screenshot from 2024-04-22 14-47-53

  3. In comparison at 90% Zoom while the ticket is generated:
    Screenshot from 2024-04-22 14-48-28

Copy link

sonarcloud bot commented Jun 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
49.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Nice to have usability Improves ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visual feedback while generate ticket event is loading
3 participants